Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the epsilon fix #216

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Clean up the epsilon fix #216

merged 2 commits into from
Jan 11, 2023

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Jan 10, 2023 •
edited
Loading

PR Summary

#215 apparently was merged prematurely. I fix the remaining issues lingering from that PR. This needs to be run on Darwin before merge.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

@Yurlungur Yurlungur added the bug Something isn't working label Jan 10, 2023
@Yurlungur Yurlungur self-assigned this Jan 10, 2023
@jhp-lanl
Copy link
Collaborator

Running the pipeline now on Darwin

@dholladay00
Copy link
Collaborator

I didn't catch this change the first time so assuming the CI passes on Darwin I approve.

jhp-lanl
jhp-lanl approved these changes Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@jhp-lanl jhp-lanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass on Darwin

@jhp-lanl jhp-lanl merged commit abef378 into main Jan 11, 2023
@jhp-lanl jhp-lanl deleted the jmm/fix-eps-fix branch January 11, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhp-lanl jhp-lanl jhp-lanl approved these changes

@dholladay00 dholladay00 Awaiting requested review from dholladay00

Assignees

@Yurlungur Yurlungur

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yurlungur @jhp-lanl @dholladay00 @jonahm-LANL